search

JCSDA-internal / ufo-data

Tier-1 test files for ufo repository
1 stars 0 forks source link

Modify IASI RTTOV test data to improve error tracking #310

Closed mikecooke77 closed 1 year ago

mikecooke77 commented 1 year ago

Description

This PR updates the IASI test file to add a missing data value for one observation into the pressureAtTopOfCloud to test the error trapping in the rttovonedvarcheck and rttov interface.

Issue(s) addressed

This links to the ufo issue: https://github.com/JCSDA-internal/ufo/issues/2644

Acceptance Criteria (Definition of Done)

All ctests passing in the companion PR at: https://github.com/JCSDA-internal/ufo/pull/2713

Dependencies

To be merged with:

Impact

Changes in ufo in the above linked PR.

mikecooke77 commented 1 year ago

I have checked the file and I can see pressureAtTopOfCloud in the MetData and TestReference groups. In TestReference I can see the following values: pressureAtTopOfCloud = 63405.49, 83614.7, 70753.87, 96737.02, _, 32435.49 ;. Is _ in fifth position expected to be there? Also, is skinTemperature not necessary to test JCSDA-internal/ufo#2713?

The _ is a missing value which has been added to test the error trapping. The skinTemperature is tested using atms. The IASI file is just used to test pressureAtTopOfCloud and cloudAmount. I thought this was sufficient as it covers the code. I appreciate in operational use we will do things differently.