search

JCSDA-internal / ufo-data

Tier-1 test files for ufo repository
1 stars 0 forks source link

release/skylab-v4: Update version to 1.6.0 in CMakeLists.txt #315

Closed climbfuji closed 1 year ago

climbfuji commented 1 year ago

Description

See title

climbfuji commented 1 year ago

@huishao-r Please review/approve, thanks!

huishao-r commented 1 year ago

@climbfuji When I checked out the release branch for ufo-data, I have one failed ctest, which shows that ufo-data/testinput_tier_1/instruments/conventional is missing sondes_uv_obs_2020121500.nc4 compared with develop

climbfuji commented 1 year ago

Take a look here: https://github.com/JCSDA-internal/ufo-data/compare/release/skylab-v4?expand=1 - I see no difference other than the version in CMakeLists.txt.

But look at this: https://github.com/JCSDA-internal/ufo-data/compare/release/skylab-v4...develop?expand=1

So somebody merged into develop after the release branch was created. I informed everyone on the JCSDA core channel when the release branch was created, so that PR should have been redirected into release/skylab-v4 instead of develop.

huishao-r commented 1 year ago

Yes. You are right. I'll inform OBS again about this!!

huishao-r commented 1 year ago

@climbfuji Should I create a PR to merge the develop change to this release branch? Thanks for figuring it out. Our fault.

climbfuji commented 1 year ago

Yes, that will work. However, we'll need to update the tarball and ask the GDEX people to upload it again.