Feature/add aircraft predictors

JCSDA-internal / ufo-data

Tier-1 test files for ufo repository

1 stars 0 forks source link

Feature/add aircraft predictors #371

Closed BrettHoover-NOAA closed 1 year ago

BrettHoover-NOAA commented 1 year ago

Description

Provides ctest data for testing ObsMetaDataPredictor function in JCSDA-internal/ufo/feature/add_aircraft_predictors

required for: https://github.com/JCSDA-internal/ufo/pull/2979

Issue(s) addressed

https://github.com/JCSDA-internal/ufo/issues/2149 https://github.com/JCSDA-internal/ufo/pull/2965 https://github.com/JCSDA-internal/ufo/pull/2979

Checklist

[x] I have performed a self-review of my own code
[x] I have made corresponding changes to the documentation
[x] I have run the unit tests before creating the PR

PatNichols commented 1 year ago

@BrettHoover-NOAA @BenjaminRuston Does the first file need to be so large to test the code in ufo? We would like it a little smalled <=1 MB. Sorry to be pain.

BrettHoover-NOAA commented 1 year ago

@PatNichols I just tried running the ctest without having access to or making reference to aircraft_geovals_20190801T0000Z_aircraft_predictors.nc4 and it still passes, I don't think we are touching the geovals file at all. @BenjaminRuston @CoryMartin-NOAA @huishao-r would it be acceptable to push a change to the ctest YAML in my ufo branch to remove references to the geovals file and remove the file entirely from this PR?

CoryMartin-NOAA commented 1 year ago

if it's not needed, I say toss it out!

BrettHoover-NOAA commented 1 year ago

geovals file was removed and ctest YAML in ufo branch was updated to not make reference to it