JCSDA-internal / ufo-data

Tier-1 test files for ufo repository
1 stars 0 forks source link

fix Channel value in satbis reference file #425

Closed huishao-r closed 5 months ago

huishao-r commented 5 months ago

Description

This PR fixes the reference files used for a few satbias coefficient tests. The fixes were discussed in the UFO issue #3329 and also the UFO PR#3330.

One of the reference files before and after the fix is shown below:

image

Issue(s) addressed

Resolves UFO issue #3329

Dependencies

None

Impact

Since the associated satbis ctest doesn't check the value of Channel in the reference file, there is no impact on the existing ctest result.

Checklist

PatNichols commented 5 months ago

@huishao-r Are we sure the ufo ci passes with the new files? Perhaps we should have waited to merge the ufo Pr until this one was available? I am going to open a dummy PR to check.

huishao-r commented 5 months ago

@PatNichols It works locally. But feel free to trigger a UFO CI. UFO PR (which we merged already) is not dependent on this, since the ctests don't check Channel values.

PatNichols commented 5 months ago

@PatNichols It works locally. But feel free to trigger a UFO CI. UFO PR (which we merged already) is not dependent on this, since the ctests don't check Channel values.

@huishao-r Thanks. I opened a test PR to check it.

PatNichols commented 5 months ago

@huishao-r it passed in the ufo ctests. Merging it now.