search

JCSDA / CRTMv3

CRTMv3 repository for coordinated development and releases. Code history is not carried in this repository prior to v3, to reduce the cloning overhead. For v2.x history leading up to v3, see JCSDA/crtm repository.
Other
6 stars 6 forks source link

fix user emissivity AD #155

Closed BenjaminTJohnson closed 3 months ago

BenjaminTJohnson commented 3 months ago

For user specified surface emissivity and scattering cases, the surface emissivity jacobian can be corrected by changing one line code: From User_Emissivity_AD = ZERO to User_Emissivity_AD = sum(SfcOptics_AD%Emissivity(1:nZ,1))

Closes: #152

BenjaminTJohnson commented 3 months ago

@chengdang I want to write a ctest for this, so I will do one more update with the test before merging.

quanhualiu commented 3 months ago

The change has been tested and I approved it.

On Wed, Aug 7, 2024 at 3:13 PM Cheng Dang @.***> wrote:

@.**** approved this pull request.

Looks good! Thank you!

— Reply to this email directly, view it on GitHub https://github.com/JCSDA/CRTMv3/pull/155#pullrequestreview-2225994602, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQCRLPFMVYP3GYBSCXCQJ63ZQJWT7AVCNFSM6AAAAABME5B5JWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMRVHE4TINRQGI . You are receiving this because you were assigned.Message ID: @.***>

BenjaminTJohnson commented 3 months ago

@chengdang would you mind testing again with the new ctests? test_User_Emissivity* Thanks!

chengdang commented 3 months ago

@BenjaminTJohnson Sorry that I missed the earlier message. Testing it now.

chengdang commented 3 months ago

All tests passed! Thanks Ben.

        Start  55: test_forward_User_Emissivity_atms_n21
 55/178 Test  #55: test_forward_User_Emissivity_atms_n21 ............   Passed    0.45 sec
        Start  56: test_forward_User_Emissivity_cris-fsr_n21
 56/178 Test  #56: test_forward_User_Emissivity_cris-fsr_n21 ........   Passed    0.36 sec
        Start  57: test_forward_User_Emissivity_v.abi_g18
 57/178 Test  #57: test_forward_User_Emissivity_v.abi_g18 ...........   Passed    0.06 sec
        Start  58: test_forward_User_Emissivity_atms_npp
 58/178 Test  #58: test_forward_User_Emissivity_atms_npp ............   Passed    0.02 sec
        Start  59: test_forward_User_Emissivity_cris399_npp
 59/178 Test  #59: test_forward_User_Emissivity_cris399_npp .........   Passed    0.10 sec
        Start  60: test_forward_User_Emissivity_v.abi_gr
 60/178 Test  #60: test_forward_User_Emissivity_v.abi_gr ............   Passed    0.06 sec
        Start  61: test_forward_User_Emissivity_abi_g18
 61/178 Test  #61: test_forward_User_Emissivity_abi_g18 .............   Passed    0.03 sec
        Start  62: test_forward_User_Emissivity_modis_aqua
 62/178 Test  #62: test_forward_User_Emissivity_modis_aqua ..........   Passed    0.03 sec
...

100% tests passed, 0 tests failed out of 178

Label Time Summary:
CRTM_Tests    = 185.87 sec*proc (178 tests)