search

JCSDA / CRTMv3

CRTMv3 repository for coordinated development and releases. Code history is not carried in this repository prior to v3, to reduce the cloning overhead. For v2.x history leading up to v3, see JCSDA/crtm repository.
Other
6 stars 6 forks source link

TL module updates for aircraft-level/user-defined-level upward/downward radiance #182

Open chengdang opened 1 month ago

chengdang commented 1 month ago

TL module updates for the following new features have been added to branch: https://github.com/JCSDA/CRTMv3/tree/feature/cd_AirCraft_TL

Besides these updates, I also included a lot of comments for the ADA module in general for future reference.

chengdang commented 1 month ago

These updates are built upon PR https://github.com/JCSDA/CRTMv3/pull/179, and should be tested after merging this PR first.

chengdang commented 1 month ago

Note 1: The computed radiance TL is assigned within module CRTM_ADA_TL, https://github.com/JCSDA/CRTMv3/blob/1a8cd44c77ad480701193fba3637379c42d6546a/src/RTSolution/ADA/ADA_Module.f90#L1623 while for the forward calculation, the radiance is assigned within Assign_Common_Output https://github.com/JCSDA/CRTMv3/blob/617b7c1df9d5b546bf35a7ad0a04bf25c0a0e8db/src/RTSolution/Common_RTSolution.f90#L1192

This is because the TL profiles are not stored in any data structure for TL modules to use outside of CRTM_ADA_TL

chengdang commented 1 month ago

Note 2:

The output of CRTM_ADA_TL is changed into a new variable s_rad_TL , which can be either upward/downward radiance TL https://github.com/JCSDA/CRTMv3/blob/1a8cd44c77ad480701193fba3637379c42d6546a/src/RTSolution/ADA/ADA_Module.f90#L1286 The original output variable s_rad_up_TL is kept as a local variable in CRTM_ADA_TL

The computed TL results are identical compare to the dev branch. (TOA only)

chengdang commented 1 month ago

Note 3:

Several ctests have been added/updated to test the model updates:

https://github.com/JCSDA/CRTMv3/blob/1a8cd44c77ad480701193fba3637379c42d6546a/test/CMakeLists.txt#L252 https://github.com/JCSDA/CRTMv3/blob/1a8cd44c77ad480701193fba3637379c42d6546a/test/CMakeLists.txt#L203 https://github.com/JCSDA/CRTMv3/blob/1a8cd44c77ad480701193fba3637379c42d6546a/test/CMakeLists.txt#L210

For now the tests run as expected.

chengdang commented 1 month ago

Note 4:

It is unclear if the TL module updates are scientifically correct, more scientific tests/code review are needed from the team.