fix a couple bugs in util/check_package_config.py

AlexanderRichert-NOAA commented 1 month ago

Summary

This PR fixes a couple bugs in util/check_package_config.py. Right now it's flagging false positives, borks when site/packages.yaml doesn't exist (like if using site={macos,linux}.default), and can't handle non-space delimited variants in packages.yaml. This can be merged after #1109.

Testing

Tested on personal machine.

Applications affected

none

Systems affected

all

Dependencies

none

Issue(s) addressed

none

Checklist

[x] This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
[x] These changes have been tested on the affected systems and applications.
[x] All dependency PRs/issues have been resolved and this PR can be merged.

climbfuji commented 1 month ago

@AlexanderRichert-NOAA The util-test failed for this PR. Do you mind taking a look?

AlexanderRichert-NOAA commented 1 month ago

@climbfuji done

JCSDA / spack-stack