JCSDA / spack-stack

Creative Commons Zero v1.0 Universal
21 stars 41 forks source link

Add netcdf-c logging variant #1136

Closed AlexanderRichert-NOAA closed 2 weeks ago

AlexanderRichert-NOAA commented 2 weeks ago

Summary

This is the spack-stack PR corresponding with https://github.com/JCSDA/spack/pull/440

Testing

Tested building with the new variant to make sure it's respected. No further testing with spack-stack since it's off by default, and we'll only enable it in certain environments.

Applications affected

Will support UFS WM and possibly others

Systems affected

none (not yet sure where the new variant will be installed)

Dependencies

https://github.com/JCSDA/spack/pull/440

Issue(s) addressed

Fixes #1045

Checklist

climbfuji commented 2 weeks ago

@AlexanderRichert-NOAA The spack PR was merged, please update this PR. Thanks!

climbfuji commented 2 weeks ago

There are no changes whatsoever in this PR?

AlexanderRichert-NOAA commented 2 weeks ago

Yeah just occurred to me we're not making it default, we'll add it to some or other environment later on. So I guess this was just for testing... :)

climbfuji commented 2 weeks ago

Yes, thanks!