create env: warn if upstream environment's config doesn't match

AlexanderRichert-NOAA commented 2 weeks ago

Summary

This PR adds a warning to the spack stack create env --upstream command if the new environment newly populated site and common directories have configs that don't match those of the upstream. It uses diff -rq, so it should work on MacOS. This will mainly be useful on HPC systems where we've made local config updates, perhaps in specific envs, that didn't get looped back into develop.

Testing

Testing on personal machine.

Applications affected

n/a

Systems affected

all

Dependencies

none

Issue(s) addressed

Fixes #1092

Checklist

[x] This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
[x] These changes have been tested on the affected systems and applications.
[x] All dependency PRs/issues have been resolved and this PR can be merged.

AlexanderRichert-NOAA commented 2 weeks ago

Yeah, I added some tests to confirm the new warnings are functioning. Meanwhile, all the workflows are failing... :upside_down_face:

climbfuji commented 2 weeks ago

must be a github glitch?

climbfuji commented 2 weeks ago

https://www.githubstatus.com/

JCSDA / spack-stack