JCSDA / spack-stack

Creative Commons Zero v1.0 Universal
27 stars 45 forks source link

Clean up templates in `config/templates` and decide what to do with `config/common/packages.yaml` #341

Open climbfuji opened 2 years ago

climbfuji commented 2 years ago

Is your feature request related to a problem? Please describe. There are too many, somewhat redundant templates in config/templates/. It's hard to keep them all up to date. Some of them pin versions of packages, which overlaps with the general config in config/common/packages.yaml.

Describe the solution you'd like Clean up the templates in config/templates. Find a better solution for specifying package versions and variants - potentially get rid of config/common/packages.yaml and maintain only a handful of templates that specify their package versions and variants directly (i.e. fixed versions for operational implementations, latest develop).

Additional context n/a

climbfuji commented 2 months ago

We're good on configs/common/packages.yaml - just need to clean up the templates in config/templates/ to close this issue.

AlexanderRichert-NOAA commented 2 months ago

Which templates are at issue here?

climbfuji commented 2 months ago

This is an old issue. We should defer that to after the release. Some of the templates haven't been updated in years, and they will no longer build (because versions aren't available anymore etc). We shouldn't keep old templates around imo - if they aren't updated and don't work, they can be removed, and brought back later if really needed? An operational implementation of something with a specific template will also point to a specific tag of spack-stack and not to develop.