search

JCSDA / spack

A flexible package manager that supports multiple versions, configurations, platforms, and compilers.
https://spack.io
Other
0 stars 14 forks source link

release/1.5.1: backport mpich4 workarounds for mapl@2.35.2 and mapl@2.40.3 #358

Closed climbfuji closed 1 year ago

climbfuji commented 1 year ago

Description

There's a PR for mapl to add workarounds for known mpich bugs: https://github.com/GEOS-ESM/MAPL/pull/2381

This PR applies these workarounds to the older mapl versions 2.35.2 and 2.40.3 that are/will be used by the UFS Weather Model.

I have tested this on Hercules with a gcc@11.3.1 + mpich@4.1.2 build. I can't tell unfortunately if the patch works as expected. While spack-stack builds fine, the ufs-weather-model doesn't build with mpich@4.1.2 due to the argument mismatch error that we know from gcc@10:.

Note. I don't intend to send this particular change back to spack develop, it's only for us supporting machines where openmpi doesn't work correctly (e.g. MSU Hercules).

Issue(s) addressed

Resolves https://github.com/JCSDA/spack-stack/issues/608

Dependencies

n/a

Impact

n/a

Checklist

mathomp4 commented 1 year ago

Ouch. That's a mighty patch!

I guess I should update the canonical MAPL spack package once https://github.com/GEOS-ESM/MAPL/pull/2381 is in and put in a fat conflict for 2.41 and lower. I'm guessing mainline spack would be concerned with patches that large.