search

JCSDA / spack

A flexible package manager that supports multiple versions, configurations, platforms, and compilers.
https://spack.io
Other
0 stars 14 forks source link

Adding ecmwf-atlas version 0.38 #453

Closed ericlingerfelt closed 3 months ago

ericlingerfelt commented 3 months ago

Adding versions 0.38.0 and 0.38.1 for ecmwf-atlas.

climbfuji commented 3 months ago

For CI testing, see https://github.com/JCSDA/spack/pull/453

climbfuji commented 3 months ago

The corresponding spack develop PR was just merged; can you confirm that you cherry-picked the commit, i.e. same commit hash for our fork and spack develop?

srherbener commented 3 months ago

@climbfuji good call! It looks like the commits don't match. This PR: 481185b750f99dcfe1ef8ffb2a929a7880124a1f Authoritative spack PR: 0b2e0a54710c851fe48a1c1f3086fb7cc1961aff

Not sure what went wrong. What's the recommended way to fix this? Thanks!

climbfuji commented 3 months ago

@climbfuji good call! It looks like the commits don't match. This PR: 481185b Authoritative spack PR: 0b2e0a5

Not sure what went wrong. What's the recommended way to fix this? Thanks!

Abandon this PR and cherry-pick the commit from spack develop probably?

srherbener commented 3 months ago

@climbfuji sounds good. I'll close this PR and start over.