search

JCSDA / ufs-bundle

Bundle for interfacing UFS models with JEDI interfaces
GNU Lesser General Public License v2.1
0 stars 3 forks source link

Feature/update apr13 #26

Closed cmgas closed 1 year ago

cmgas commented 1 year ago

Description

Update with develop on april 13.

Waiting on https://github.com/JCSDA-internal/fv3-jedi-data/pull/71 https://github.com/JCSDA-internal/soca/pull/864 https://github.com/JCSDA-internal/fv3-jedi/pull/847

climbfuji commented 1 year ago

Testing this now!

climbfuji commented 1 year ago

This doesn't work for me :-( On my Mac, I get the following error when I run the UFS ctests (warmstart):

1197: At line 47 of file /Users/heinzell/scratch/ufs-bundle/ufs-bundle-clem-apr13/fv3-jedi/src/fv3jedi/Utilities/fv3jedi_constants_mod.f90
1197: Fortran runtime error: Different CHARACTER lengths (7/1) in array constructor
1197: At line 47 of file /Users/heinzell/scratch/ufs-bundle/ufs-bundle-clem-apr13/fv3-jedi/src/fv3jedi/Utilities/fv3jedi_constants_mod.f90
1197: Fortran runtime error: Different CHARACTER lengths (7/1) in array constructor
1197: At line 47 of file /Users/heinzell/scratch/ufs-bundle/ufs-bundle-clem-apr13/fv3-jedi/src/fv3jedi/Utilities/fv3jedi_constants_mod.f90
1197: Fortran runtime error: Different CHARACTER lengths (7/1) in array constructor
1197: At line 47 of file /Users/heinzell/scratch/ufs-bundle/ufs-bundle-clem-apr13/fv3-jedi/src/fv3jedi/Utilities/fv3jedi_constants_mod.f90
1197: Fortran runtime error: Different CHARACTER lengths (7/1) in array constructor
1197: At line 47 of file /Users/heinzell/scratch/ufs-bundle/ufs-bundle-clem-apr13/fv3-jedi/src/fv3jedi/Utilities/fv3jedi_constants_mod.f90
1197: Fortran runtime error: Different CHARACTER lengths (7/1) in array constructor
1197: At line 47 of file /Users/heinzell/scratch/ufs-bundle/ufs-bundle-clem-apr13/fv3-jedi/src/fv3jedi/Utilities/fv3jedi_constants_mod.f90
1197: Fortran runtime error: Different CHARACTER lengths (7/1) in array constructor
1197: [JCSDA-L-18146:79842] *** Process received signal ***
cmgas commented 1 year ago

Rebuilding now with latest develops

climbfuji commented 1 year ago

@cmgas This works now! The only thing that's needed on my macOS is updating the reference value for the ufs warmstart test:

difference between 355.7572273542616 and 356.73198629080974 is 0.97475893654814172, i.e. exceeds 0.035673198629080978 (FAIL)
climbfuji commented 1 year ago

Other good news: I was able to build the atmaero configuration on my macOS as well, will try ng-godas next

cmgas commented 1 year ago

@climbfuji When we merge the soca, fv3-jedi and fv3-jedi-data I will update the ufs-bundle PR

climbfuji commented 1 year ago

Would be nice to have a list of all PRs that this PR is waiting on in the description ...

climbfuji commented 1 year ago

Hmm, bad news at last. S2S compile failed on my macOS with:

[ 90%] Built target fv3jedi_addincrement.x
/Applications/Xcode.app/Contents/Developer/usr/bin/make  -f fv3-jedi/src/mains/CMakeFiles/fv3jedi_addincrement.x.schema.json.dir/build.make fv3-jedi/src/mains/CMakeFiles/fv3jedi_addincrement.x.schema.json.dir/depend
cd /Users/heinzell/scratch/ufs-bundle/build-debug-s2s && /usr/local/Cellar/cmake/3.23.1/bin/cmake -E cmake_depends "Unix Makefiles" /Users/heinzell/scratch/ufs-bundle/ufs-bundle-clem-apr13 /Users/heinzell/scratch/ufs-bundle/ufs-bundle-clem-apr13/fv3-jedi/src/mains /Users/heinzell/scratch/ufs-bundle/build-debug-s2s /Users/heinzell/scratch/ufs-bundle/build-debug-s2s/fv3-jedi/src/mains /Users/heinzell/scratch/ufs-bundle/build-debug-s2s/fv3-jedi/src/mains/CMakeFiles/fv3jedi_addincrement.x.schema.json.dir/DependInfo.cmake --color=
/Applications/Xcode.app/Contents/Developer/usr/bin/make  -f fv3-jedi/src/mains/CMakeFiles/fv3jedi_addincrement.x.schema.json.dir/build.make fv3-jedi/src/mains/CMakeFiles/fv3jedi_addincrement.x.schema.json.dir/build
cd /Users/heinzell/scratch/ufs-bundle/build-debug-s2s/etc && /Users/heinzell/scratch/ufs-bundle/build-debug-s2s/bin/fv3jedi_addincrement.x --output-json-schema=fv3jedi_addincrement.x.schema.json
dyld[72844]: Library not loaded: libpiof.dylib
  Referenced from: /Users/heinzell/scratch/ufs-bundle/build-debug-s2s/bin/fv3jedi_addincrement.x
  Reason: tried: 'libpiof.dylib' (no such file), '/usr/local/lib/libpiof.dylib' (no such file), '/usr/lib/libpiof.dylib' (no such file), '/Users/heinzell/scratch/ufs-bundle/build-debug-s2s/etc/libpiof.dylib' (no such file), '/usr/local/lib/libpiof.dylib' (no such file), '/usr/lib/libpiof.dylib' (no such file)
/bin/sh: line 1: 72844 Abort trap: 6           /Users/heinzell/scratch/ufs-bundle/build-debug-s2s/bin/fv3jedi_addincrement.x --output-json-schema=fv3jedi_addincrement.x.schema.json
make[2]: *** [fv3-jedi/src/mains/CMakeFiles/fv3jedi_addincrement.x.schema.json] Error 134
make[1]: *** [fv3-jedi/src/mains/CMakeFiles/fv3jedi_addincrement.x.schema.json.dir/all] Error 2
make: *** [all] Error 2

This works with the current ufs-bundle develop.

climbfuji commented 1 year ago

Hmm, bad news at last. S2S compile failed on my macOS with:

[ 90%] Built target fv3jedi_addincrement.x
/Applications/Xcode.app/Contents/Developer/usr/bin/make  -f fv3-jedi/src/mains/CMakeFiles/fv3jedi_addincrement.x.schema.json.dir/build.make fv3-jedi/src/mains/CMakeFiles/fv3jedi_addincrement.x.schema.json.dir/depend
cd /Users/heinzell/scratch/ufs-bundle/build-debug-s2s && /usr/local/Cellar/cmake/3.23.1/bin/cmake -E cmake_depends "Unix Makefiles" /Users/heinzell/scratch/ufs-bundle/ufs-bundle-clem-apr13 /Users/heinzell/scratch/ufs-bundle/ufs-bundle-clem-apr13/fv3-jedi/src/mains /Users/heinzell/scratch/ufs-bundle/build-debug-s2s /Users/heinzell/scratch/ufs-bundle/build-debug-s2s/fv3-jedi/src/mains /Users/heinzell/scratch/ufs-bundle/build-debug-s2s/fv3-jedi/src/mains/CMakeFiles/fv3jedi_addincrement.x.schema.json.dir/DependInfo.cmake --color=
/Applications/Xcode.app/Contents/Developer/usr/bin/make  -f fv3-jedi/src/mains/CMakeFiles/fv3jedi_addincrement.x.schema.json.dir/build.make fv3-jedi/src/mains/CMakeFiles/fv3jedi_addincrement.x.schema.json.dir/build
cd /Users/heinzell/scratch/ufs-bundle/build-debug-s2s/etc && /Users/heinzell/scratch/ufs-bundle/build-debug-s2s/bin/fv3jedi_addincrement.x --output-json-schema=fv3jedi_addincrement.x.schema.json
dyld[72844]: Library not loaded: libpiof.dylib
  Referenced from: /Users/heinzell/scratch/ufs-bundle/build-debug-s2s/bin/fv3jedi_addincrement.x
  Reason: tried: 'libpiof.dylib' (no such file), '/usr/local/lib/libpiof.dylib' (no such file), '/usr/lib/libpiof.dylib' (no such file), '/Users/heinzell/scratch/ufs-bundle/build-debug-s2s/etc/libpiof.dylib' (no such file), '/usr/local/lib/libpiof.dylib' (no such file), '/usr/lib/libpiof.dylib' (no such file)
/bin/sh: line 1: 72844 Abort trap: 6           /Users/heinzell/scratch/ufs-bundle/build-debug-s2s/bin/fv3jedi_addincrement.x --output-json-schema=fv3jedi_addincrement.x.schema.json
make[2]: *** [fv3-jedi/src/mains/CMakeFiles/fv3jedi_addincrement.x.schema.json] Error 134
make[1]: *** [fv3-jedi/src/mains/CMakeFiles/fv3jedi_addincrement.x.schema.json.dir/all] Error 2
make: *** [all] Error 2

This works with the current ufs-bundle develop.

I believe that this is an error in the parallelio package itself. Not sure why it didn't show up until now. I'll do a bit more digging if we can work around it, but in the meanwhile we should start merging the upstream dependencies of this PR.

climbfuji commented 1 year ago

The three upstream dependencies have been merged.

cmgas commented 1 year ago

@climbfuji I updated all the branches to be feature/ufs_dom