JCSDA / ufs-bundle

Bundle for interfacing UFS models with JEDI interfaces
GNU Lesser General Public License v2.1
0 stars 3 forks source link

Fix failing CI tests (CRTM cmake errors) and remove dependency on `w3nco` #48

Closed climbfuji closed 9 months ago

climbfuji commented 9 months ago

Description

  1. Use tag v3.1.0-skylabv7 for CRTM until problems with recently introduced plain cmake build are resolved
  2. Remove dependency on w3nco (replaced by w3emc); for more details see associated PR https://github.com/JCSDA-internal/fv3-jedi/pull/1127

Note. Once https://github.com/JCSDA-internal/fv3-jedi/pull/1127 is merged, need to revert the temporary branch name change for fv3-jedi

Issue(s) addressed

Resolves failing CI tests

This is a workaround for https://github.com/JCSDA/ufs-bundle/issues/49 (not a solution)

Dependencies

Impact

n/a

Checklist

climbfuji commented 9 months ago

@shlyaeva can you take a look at this PR when you have time, please?

@eap - FYI This PR was approved by Ben J beforehand, but the approval was dismissed when I pushed the latest commit.

shlyaeva commented 9 months ago

@climbfuji can you explain in a few words why this only affects ufs-bundle but not jedi-bundle? (or does it also affect jedi-bundle?)

climbfuji commented 9 months ago

@climbfuji can you explain in a few words why this only affects ufs-bundle but not jedi-bundle? (or does it also affect jedi-bundle?)

I can: I have no idea. But I assume it's because of the way we build the code - that whole mix and match of ecbuild packages for most packages, plain cmake for crtm, cmake external project for ufs-weather-model, is a fragile configuration. Going back to the release tag where crtm was an ecbuild package works. In jedi-bundle, we don't have all of that.