JCWasmx86 / mesonlsp

An unofficial, unendorsed language server for meson written in C++
GNU General Public License v3.0
64 stars 8 forks source link

Subproject check does not understand f-strings #114

Closed QuLogic closed 4 months ago

QuLogic commented 4 months ago

Describe the bug In Matplotlib, we have a subproject call that uses an f-string with a version: https://github.com/matplotlib/matplotlib/blob/main/extern/meson.build#L19-L21 With mesonlsp, this produces a warning:

Unknown subproject `freetype-@LOCAL_FREETYPE_VERSION@`

To Reproduce Steps to reproduce the behavior:

  1. Clone https://github.com/matplotlib/matplotlib
  2. Open extern/meson.build
  3. Go to line 19
  4. See error noted above.

Expected behavior No warning, as there is a subproject for the evaluated string, i.e. if I replace the substitution with a hard-coded string, then mesonlsp stops complaining.

System info

JCWasmx86 commented 4 months ago

I implemented it quickly. It works as long as there is only one variable.