search

JCWasmx86 / mesonlsp

An unofficial, unendorsed language server for meson written in C++
GNU General Public License v3.0
64 stars 8 forks source link

Document link for subdir() #131

Closed Freed-Wu closed 3 months ago

Freed-Wu commented 3 months ago

Is your feature request related to a problem? Please describe. subdir("XXX") will provide a document link to XXX/meson.build

Describe the solution you'd like A clear and concise description of what you want to happen.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Will you write a patch?

Will you maintain it, if you submit a patch?

Additional context Add any other context or screenshots about the feature request here.

JCWasmx86 commented 3 months ago

It already works

https://github.com/user-attachments/assets/fed203ac-c126-40b9-a3ed-d03cd295d66f

And please try to follow the template the next time

JCWasmx86 commented 3 months ago

No response/clarification. Closing

Freed-Wu commented 3 months ago

I use mesonlsp 4.3.3. Does this feature belong next version?

JCWasmx86 commented 3 months ago

It's already implemented since 4.0.0

Freed-Wu commented 2 months ago

It is realized as gotoDefintion, not DocumentLink

JCWasmx86 commented 2 months ago

It currently works fine, what's the advantage of implementing it with document links? Please follow the issue template

Freed-Wu commented 2 months ago

Document link can allow user display the URL. For example clangd realize #include as gotoDefinition and Document link.

Screenshot from 2024-08-27 22-52-47

JCWasmx86 commented 2 months ago

I won't implement it, due to missing time, but patches are welcome