search

JChristensen / DS3232RTC

Arduino Library for Maxim Integrated DS3232 and DS3231 Real-Time Clocks
GNU General Public License v3.0
394 stars 137 forks source link

Use TimeLib.h, for compatibility with Arduino 1.6.10 (newer avr-libc) #30

Closed PaulStoffregen closed 6 years ago

PaulStoffregen commented 8 years ago

Newer versions of the Time library use TimeLib.h. This has been necessary for some time on 32 bit ARM chips, because the C library has a file named "time.h" which conflicts on Windows and Mac case-insensitive filesystems. Now Arduino 1.6.10 has an updated C library for AVR which also conflicts.

Here's a recent report of the problem: http://forum.arduino.cc/index.php?topic=415314.msg2860438#msg2860438

Please apply this simple patch to use TimeLib.h instead of Time.h.

JChristensen commented 8 years ago

Hi Paul, thanks for the PR. I've been mostly out of the loop on this stuff for awhile. Would the comments in the code like this one be better off pointing to https://github.com/PaulStoffregen/Time instead of to http://www.arduino.cc/playground/Code/Time?

PaulStoffregen commented 8 years ago

Either link is fine.

PaulStoffregen commented 8 years ago

I'd just go with the simplest, smallest change... pretty much just this pull request.

That URL on Arduino's site should be long-term stable, and it links to the github page. My advice would be "ain't broke, don't fix". ;-)