search

JChristensen / DS3232RTC

Arduino Library for Maxim Integrated DS3232 and DS3231 Real-Time Clocks
GNU General Public License v3.0
392 stars 135 forks source link

TimeRTC example #89

Closed roblatour closed 3 years ago

roblatour commented 3 years ago

The TimeRTC example is missing the line:

DS3232RTC RTC;

and as is it will not compile.

JChristensen commented 3 years ago

It compiles OK for an Uno. What board are you using? See the documentation for the constructor. Defining a DS3232RTC object for other architectures is left as an exercise for the user ;-)

roblatour commented 3 years ago

An esp32 devkit 1

Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10

From: Jack @.> Sent: April 5, 2021 11:27 AM To: @.> Cc: Rob @.>; @.> Subject: Re: [JChristensen/DS3232RTC] TimeRTC example (#89)

It compiles OK for an Uno. What board are you using? See the documentation for the constructorhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJChristensen%2FDS3232RTC%23ds3232rtcbool-initi2c&data=04%7C01%7C%7C956987ea1bb74ec264bf08d8f8475969%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637532332612394974%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=VpqIEgPB4lR1zHOY98q7mFVsMv3mxSUaLrRB9YvbPBc%3D&reserved=0. Defining a DS3232RTC object for other architectures is left as an exercise for the user ;-)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJChristensen%2FDS3232RTC%2Fissues%2F89%23issuecomment-813453711&data=04%7C01%7C%7C956987ea1bb74ec264bf08d8f8475969%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637532332612404974%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=EZKK4sCwM4hFmBBatPGhAcDEAwBXQlG7qJXi0xu9ltQ%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABHVWWQUIHD2Z6NSXJ7JXQ3THHJGVANCNFSM42M2S33A&data=04%7C01%7C%7C956987ea1bb74ec264bf08d8f8475969%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637532332612414974%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=JLbEGZtyx24vzLt00%2BStmNbJC4zNpo76G3%2FDFshyZAo%3D&reserved=0.

JChristensen commented 3 years ago

Working as advertised then, I guess. While the example could be modified to include an instantiation of a DS3232RTC object, this is not without (a perhaps small) risk. If someone just copies the example, they could end up with an extra, unneeded object. Or the example could be modified with conditional compilation. Pros and cons to all of this, but overall I think it's a small issue. Maybe I will revisit in the future.