search

JChristensen / JC_Button

Arduino library to debounce button switches, detect presses, releases, and long presses
GNU General Public License v3.0
425 stars 102 forks source link

no syntax highlighting when library is included #25

Closed thoschneider closed 5 years ago

thoschneider commented 5 years ago

Hello! Unfortunately there is no syntax highlighting when the library is included. I think adding the line "JC_Button Keyword1" to keywords.txt does the trick.

(As I read "Keyword1" should be used for classes. You named your class "Button", but the name of your libary is "JC_Button". Without adding "JC_Button Keyword1" to keywords.txt there is no syntax highlighting when library is included.)

JChristensen commented 5 years ago

Not sure I'm understanding. What specifically is not highlighted? Here is what I see for one of the example sketches:

SimpleOnOff

thoschneider commented 5 years ago

Dear Mr. Christensen,

maybe it is a coincidence, but in all the sketches I used so far, the included header file was highlighted in orange (because the name of the header file matched a class name in that file). See screenshot attached.

Me and my students found this highlighting very convenient indicating that the library is (properly) installed. Adding "JC_Button KEYWORD1" to keywords.txt would suit this purpose.

It is not a big deal, just a naming convention perhaps. I hope you get my point.

Best regards

Thomas

Am Donnerstag, 3. Oktober 2019, 00:12:01 CEST schrieb Jack Christensen:

Not sure I'm understanding. What specifically is not highlighted? Here is what I see for one of the example sketches:

SimpleOnOff

JChristensen commented 5 years ago

Hello Thomas,

Your screenshot doesn't seem to be showing for me but it sounds like you are just talking about the #include statement. Adding the line to the keywords file as you suggest should fix that. Look for it in a day or two.

Cheers ... Jack

thoschneider commented 5 years ago

Yes, only the #include statement.

Thomas

Am Donnerstag, 3. Oktober 2019, 03:35:45 CEST schrieb Jack Christensen:

Hello Thomas,

Your screenshot doesn't seem to be showing for me but it sounds like you are just talking about the #include statement. Adding the line to the keywords file as you suggest should fix that. Look for it in a day or two.

Cheers ... Jack

JChristensen commented 5 years ago

I'm just curious, you mentioned your students. What level are you teaching at?

thoschneider commented 5 years ago

I offer some arduino courses in an "MINT"-association (math,informatics,natural sciences) for kids and teens from 12-16 years. I am a highschool teacher for physics and biology and since three years I sporadically offer some arduino projects.

Cheers, Thomas

Am 03.10.2019 18:21 schrieb Jack Christensen:

I'm just curious, you mentioned your students. What level are you teaching at?

-- You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub [1], or mute the thread [2].

Links:

[1] https://github.com/JChristensen/JC_Button/issues/25?email_source=notifications&email_token=ANL7BP4QRQGMINLHC34RP63QMYLWZA5CNFSM4I433EN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAIYAZI#issuecomment-538017893 [2] https://github.com/notifications/unsubscribe-auth/ANL7BPZZHKAYQBI7XVU2573QMYLWZANCNFSM4I433ENQ

JChristensen commented 5 years ago

Very cool. I've tried that once or twice on a very small scale with friends' kids, but I am not a teacher so I'm not too good at it!