JChristensen / JC_Button

Arduino library to debounce button switches, detect presses, releases, and long presses
GNU General Public License v3.0
425 stars 102 forks source link

Compilation warning when working with Arduino Rev4 #36

Closed gstavrinos closed 1 year ago

gstavrinos commented 1 year ago

The specific warning is this one: WARNING: library JC_Button claims to run on avr architecture(s) and may be incompatible with your current board which runs on renesas_uno architecture(s).

Are there any known problems? Can the warning be safely ignored?

If there are concerns, I would be happy to help out, if I can.

Thanks for any reply and your work so far with the library!

davidmpye commented 1 year ago

The issue is that the author hasnt marked the library as compatible with that architecture (and has chosen not to do so).

The library contains no platform-specific code.

David

On Sat, 30 Sept 2023 at 15:59, George Stavrinos @.***> wrote:

The specific warning is this one: WARNING: library JC_Button claims to run on avr architecture(s) and may be incompatible with your current board which runs on renesas_uno architecture(s).

Are there any known problems? Can the warning be safely ignored?

If there are concerns, I would be happy to help out, if I can.

Thanks for any reply and your work so far with the library!

— Reply to this email directly, view it on GitHub https://github.com/JChristensen/JC_Button/issues/36, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARIHYLEEDHGHHQ7UYTI6IDX5AXUBANCNFSM6AAAAAA5NTOXFA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

JChristensen commented 1 year ago

Are there any known problems? Can the warning be safely ignored?

Unknown. As noted, the library does not contain platform specific code, so my gut feel is that it should be OK but there are no guarantees. My work is pretty much limited to the AVR architecture; I cannot keep up with all the new boards and architectures. I am a bit reticent to offer my code as approved for hardware that I have not personally tested and cannot debug any issues on.

If the warning bothers you, in the library.properties file, just change architectures=avr to architectures=*

Thanks for the kind words and good luck with your project.