JDA-Applications / JDA-Utilities

A series of tools and utilities for JDA to assist in bot creation
Apache License 2.0
215 stars 108 forks source link

Make JDA Utils only set Activity when set. #110

Open Andre601 opened 4 years ago

Andre601 commented 4 years ago

Pull Request

Pull Request Checklist

Please follow the following steps before opening this PR.
PRs that do not complete the checklist will be subject to denial for missing information.

Pull Request Information

Check and fill in the blanks for all that apply:

Description

By default does JDA Utilities set the Activity no matter what. When providing null does it still set the activity which results in no activity being set at all.

This is annoying, especially considering that this is done in the ReadyEvent and could have conflicts with bots that also set the Activity on the ReadyEvent.

This PR adds a simple check, that will JDA Utils only set the Activity when the provided activity isn't null. This allows the usage of the Command package while still using their own method(s) to set a bots activity.