update to latest jda version

JDA-Applications / JDA-Utilities

A series of tools and utilities for JDA to assist in bot creation

Apache License 2.0

218 stars 111 forks source link

update to latest jda version #130

Closed 0ptk closed 3 years ago

0ptk commented 3 years ago

Pull Request

Pull Request Checklist

Please follow the following steps before opening this PR.
PRs that do not complete the checklist will be subject to denial for missing information.

[X] I have checked the pull request page for upcoming or merged features/bug fixes.
[X] I have read JDA's contributing guidelines.

Pull Request Information

Check and fill in the blanks for all that apply:

[X] My PR fixes a bug, error, or other issue with the library's codebase.
[ ] My PR is for the ______ module of the JDA-Utilities library.
[ ] My PR creates a new module for the JDA-Utilities library: ______.

Description

I updated jda version to latest and small fix codes

nikii-me commented 3 years ago

JDA-Utilities has been dead since quite a while, so I doubt this will be merged anytime soon. You might want to look into forks or even a different library.

Sanduhr32 commented 3 years ago

You broke several core functionalities of "Builder" classes by returning void disallowing chaining. This PR will most likely not be merged unless you undo most changes breaking how JDA Utils is set up.

Andre601 commented 3 years ago

As it was mentioned is this project abandoned. You should consider using chew/JDA-Chewtils which is updated and maintsined.

Also, as sanduhr mentioned does your PR also break everything.

Sanduhr32 commented 3 years ago

English? Do you speak it? @Andre601 Andtre you must formulate declarative sentences not questions.

Andre601 commented 3 years ago

English? Do you speak it? @Andre601 Andtre you must formulate declarative sentences not questions.

Shush. I don't complain about your speech-skills so I expect the same from you. My points where clear enough.

Sanduhr32 commented 3 years ago

This was a friendly reminder that verb noun most likely is used for questioning. You do not try to question stuff right now your answer is a redundancy with incorrect language. I hereby politely ask you to fix your incorrect chaining of verb and noun to noun and verb.

MinnDevelopment commented 3 years ago

Closing since the majority of changes introduced by this PR are completely unrelated to updating JDA. They are mostly superfluous and in some cases outright breaking and even introduce bugs.