[Enhancement] Now allow for custom implementations of EventWaiter

Shengaero commented 6 years ago

Pull Request

Pull Request Checklist

Please follow the following steps before opening this PR.
PRs that do not complete the checklist will be subject to denial for missing information.

[X] I have checked the pull request page for upcoming or merged features/bug fixes.
[X] I have read JDA's contributing guidelines.

Pull Request Information

Check and fill in the blanks for all that apply:

[ ] My PR fixes a bug, error, or other issue with the library's codebase.
[X] My PR is for the commons module of the JDA-Utilities library.
[ ] My PR creates a new module for the JDA-Utilities library: ______.

Description

Due to the recent EventWaiter requests (among them, asynchronous dispatch of EventListener#onEvent, concurrent-modification support, and others I am probably missing), there will now be a new interface as part of the commons module: IEventWaiter

This will allow for developers to have even the tiniest specifications they might desire at their disposal when dealing with the menus in the menu module, and other general specifics.

An example implementation in kotlin can be found here.

Please note that if you currently use EventWaiter this PR is 100% backwards compatible, and you should have no codebase changes required upon the release of next version.

Shengaero commented 6 years ago

This newest commit should also address #60 For anyone who still encounters issues, you should consider implementing IEventWaiter

schnapster commented 6 years ago

Any help needed to move this PR along? Suffering from #60

Shengaero commented 6 years ago

@napstr if you absolutely need this PR right now, you can check it out via jitpack.

Andre601 commented 4 years ago

Just wanted to point out that the linked Gist is invalid (doesn't exist)

JDA-Applications / JDA-Utilities