Open kantenkugel opened 6 years ago
Please follow the following steps before opening this PR. PRs that do not complete the checklist will be subject to denial for missing information.
Check and fill in the blanks for all that apply:
menu
commons
______
This module adds the possibility to cancel EventWaiter tasks via the new return value of EventWaiter#waitForEvent (Future<Void>)
EventWaiter
EventWaiter#waitForEvent
Future<Void>
This new feature is used to add Menu#cancel() to cancel menus that are already running.
Menu#cancel()
cancelFuture.cancel(true)
false
display()
Should probably also wait for #58 to be merged so i can apply the changes from this PR to that code as well. Adding it to the TODO
Pull Request
Pull Request Checklist
Please follow the following steps before opening this PR.
PRs that do not complete the checklist will be subject to denial for missing information.
Pull Request Information
Check and fill in the blanks for all that apply:
menu
andcommons
modules of the JDA-Utilities library.______
.Description
This module adds the possibility to cancel
EventWaiter
tasks via the new return value ofEventWaiter#waitForEvent
(Future<Void>
)This new feature is used to add
Menu#cancel()
to cancel menus that are already running.Todo:
cancelFuture.cancel(true)
vsfalse
display()
if already being displayed somewhere, as this would currently prevent proper functionality ofMenu#cancel()