Example Code Cleanup

[JonoAugustine]

Pull Request

Pull Request Checklist

Please follow the following steps before opening this PR.
PRs that do not complete the checklist will be subject to denial for missing information.

• [X] I have checked the pull request page for upcoming or merged features/bug fixes.
• [X] I have read JDA's contributing guidelines.

Pull Request Information

Check and fill in the blanks for all that apply:

• [ ] My PR fixes a bug, error, or other issue with the library's codebase.
• [X] My PR is for the Example module of the JDA-Utilities library.
• [ ] My PR creates a new module for the JDA-Utilities library: ______.

Description

I have improved the readability of the About and GuildList example commands so that newcomers can get a better grasp on how it all works.

Both

• Max line ~80-90 char
• Spaced out chained .append() calls Guild List
• Added Bot-Human % to each guild
• Paginates w/ numbered items About
• Extracted sending code to send(event) and placed inside of getApplicationInfo.queue for failure and success responses so building the InvLink doesn't use complete()
• Changed features param to Command[] commands
  • Makes setup simpler
• Added 2 more constructors, 1 which takes a pre-made Invite link instead of a permission array

[jagrosh]

Right off the bat, please don't change the copyright, and please don't remove the original author from the file if you are modifying it.

[JonoAugustine]

woopsies, force of habit. ill change that

[MinnDevelopment]

It would be extremely helpful to include some kind of description or explanation as to what these changes exactly improve/change.

[jagrosh]

I also noticed you included a sun import, which is probably not very good practice considering some people might be building on OpenJDK or future releases. There is a JDA util called Checks that might have similar functionality and is already a dependency.

[JonoAugustine]

I also noticed you included a sun import, which is probably not very good practice considering some people might be building on OpenJDK or future releases. There is a JDA util called Checks that might have similar functionality and is already a dependency.

Thanks, was unaware of this

[JonoAugustine]

@MinnDevelopment updated description