JDACS4C-IMPROVE / IMPROVE

Libraries and scripts for basic IMPROVE functionalities
MIT License
1 stars 3 forks source link

Please update the requirements file with actual requirements and not a conda dump. #115

Closed wilke closed 2 weeks ago

wilke commented 2 months ago
          Please update the requirements file with actual requirements and not a conda dump.

Originally posted by @wilke in https://github.com/JDACS4C-IMPROVE/IMPROVE/pull/114#pullrequestreview-2293717909

jonesse3 commented 2 months ago

We possibly don't need this file. I got it to work doing the following:

conda create -n parsl parsl -y
conda activate parsl 
nkoussa commented 2 months ago

conda create -n parsl parsl numpy pandas scikit-learn pyyaml -y

jonesse3 commented 2 months ago

If we want to start using improvelib from PyPi, we can do the following:

conda create -n parsl parsl python==3.7 -y
conda activate parsl
pip install improvelib

Otherwise, what Natasha wrote above includes what we need to install to run improvelib from the IMPROVE repo.

adpartin commented 3 weeks ago

conda create -n parsl parsl numpy pandas scikit-learn pyyaml -y

@priyanka9991 We should add this to this README https://github.com/JDACS4C-IMPROVE/IMPROVE/tree/develop/workflows/parsl_csa

jonesse3 commented 2 weeks ago

Should we delete this file, https://github.com/JDACS4C-IMPROVE/IMPROVE/blob/develop/workflows/parsl_csa/parsl_env.yml, or have a cleaner version?

priyanka9991 commented 2 weeks ago

Good catch. Yes we should delete it.

jonesse3 commented 2 weeks ago

Issue completed