JDACS4C-IMPROVE / IMPROVE

Libraries and scripts for basic IMPROVE functionalities
MIT License
1 stars 3 forks source link

Make o/p directories for logging if not created already #144

Closed priyanka9991 closed 4 weeks ago

priyanka9991 commented 4 weeks ago

@wilke pointed out that if the subprocess call fails inside the parsl app for some reason (eg: missing model scripts), the corresponding output dirs (model_dir, infer_dir or ml_data_dir) will not be created. So, we need to check if the output directories exist and create them if needed, to save the log files.

adpartin commented 4 weeks ago

@priyanka9991 did you have a chance to test it? It looks good, but I assume it wouldn't work as is. I think os should be imported inside each python_app.

priyanka9991 commented 4 weeks ago

@adpartin Thanks for catching that. I added the imports inside the apps. Also tested on GraphDRP.