search

JDAI-CV / fast-reid

SOTA Re-identification Methods and Toolbox
Apache License 2.0
3.42k stars 837 forks source link

DefaultPredictor does not normalize the output #718

Closed seermer closed 8 months ago

seermer commented 10 months ago

Instructions To Reproduce the 🐛 Bug:

https://github.com/JDAI-CV/fast-reid/blob/817c748e8c44ed8c12c3e95de355610c094fade1/fastreid/engine/defaults.py#L153

The output of DefaultPredictor is never normalized. However, cosine similarity calculation requires normalized embedding. This bug also causes wrong ranking/visualization as shown in a previous issue https://github.com/JDAI-CV/fast-reid/issues/651#issue-1194006183

Expected behavior:

either normalization should be done outside the predictor every time, or there should be normalization inside predictor

Environment:

problem exists in master branch

github-actions[bot] commented 9 months ago

This issue is stale because it has been open for 30 days with no activity.

github-actions[bot] commented 8 months ago

This issue was closed because it has been inactive for 14 days since being marked as stale.