JDAI-CV / fast-reid

SOTA Re-identification Methods and Toolbox
Apache License 2.0
3.39k stars 830 forks source link

No normalization in demo/visualize_result.py #733

Open jsheo96 opened 1 month ago

jsheo96 commented 1 month ago

In demo/visualie_result.py file there is following code snippet at line 125~126

 # compute cosine distance
    distmat = 1 - torch.mm(q_feat, g_feat.t())

I think there should be a nomalization before torch.mm like "postprocess" function in demo/demo.py

The resulting jpg outputs also show the similarities over 1, which is weird behavior.

github-actions[bot] commented 1 week ago

This issue is stale because it has been open for 30 days with no activity.