search

JDBurnZ / pyminfraud

A Python library to interface with MaxMind's MinFraud web service API.
Other
2 stars 7 forks source link

Fixed encoding requirement with MD5 function in Python 3 #6

Closed faraday closed 9 years ago

faraday commented 9 years ago

hashlib.md5 requires its input to be encoded otherwise it refuses to work in Python 3

@JDBurnZ

faraday commented 9 years ago

I just published my own version with this PR added to PyPI: https://pypi.python.org/pypi/pyminfraud/1.0.2.dev1

I added .dev1 suffix to keep the version as something specific

Is this alright? @JDBurnZ

JDBurnZ commented 9 years ago

That's great, I appreciate you taking the time to do this.

On Mon, Apr 13, 2015 at 10:30 AM, Çağatay Çallı notifications@github.com wrote:

I just published my own version with this PR added to PyPI: https://pypi.python.org/pypi/pyminfraud/1.0.2.dev1

I added .dev1 suffix to keep the version as something specific

Is this alright? @JDBurnZ https://github.com/JDBurnZ

— Reply to this email directly or view it on GitHub https://github.com/JDBurnZ/pyminfraud/pull/6#issuecomment-92381084.

ibrahimsag commented 9 years ago

@JDBurnZ anything blocking this?