search

JDCTeam / issue_tracking_cm

4 stars 0 forks source link

Ledify? #105

Open mrrhye opened 7 years ago

mrrhye commented 7 years ago

My led is staying on after boot, even when screen is off. Have tried disabling boot led in ledify, then tried disabling toolbox but led still flashing. Have reinstalled with success untill i did a nand backup on reboot it stayed on again. Have not changed rom in any way eg kernel, xposed or sys mods.

dkati commented 7 years ago

Hello :) I will check it

B--B commented 7 years ago

Take a look at the ramdisk, probably something is messed there and led is not disabled after boot complete (it's just an idea, haven't checked sources cause I have no time now, sorry)

dkati commented 7 years ago

Can't be ram disk since doesn't happen to other variants. Check the questions I did to u one day, @b--b

B--B commented 7 years ago

What rom and variant is affected by this issue?

dkati commented 7 years ago

First of all we do not know which rom is causing that.

B--B commented 7 years ago

So we are suppose to fix a bug that we don't know in what rom happens? Funny

dkati commented 7 years ago

I made some changes to Optcm 13 about ledify. But it was a bit strange at cm14 too. I work on both roms together so yes I would check it. Since the bug is reported on cm issue tracking I guess it's one of those 2

B--B commented 7 years ago

I don't see any change in ledify script, what did you change exactly?

dkati commented 7 years ago

i did nothing to ledifys script

those was just missing https://github.com/JDCTeam/android_device_samsung_jf-common/commit/dc97747048c775cc0790bd3f95ead34a1b8e8f85

B--B commented 7 years ago

You ported some N changes from my ramdisk like systemless root support that probably breaks some things, if you are compiling with that ramdisk probably kernel scripts are completely broken for non-systemless supersu

dkati commented 7 years ago

yes i did so.

I use systemless root :)

B--B commented 7 years ago

https://github.com/JDCTeam/Ramdisk/commit/ef95737ddf357990d233dc15396615b65c42f329 this seems completely wrong as the same things are handled by kernel scripts and by stweaks

dkati commented 7 years ago

generally ,the ramdisk is messed up... I lack of knowledge how to stabilize it :/ ... this commit though,stabilized rom .some strange things like cpu stucks are less often(still there tho) I also found some instability of stweaks.btw...

Generally stweaks and ramdisk are too deep for me.cant make them work as i want to

B--B commented 7 years ago

Then probably your issues are all related to ramdisk, as I don't see anything similar on mm.. Same for ledify, it's working as it should without any issues..

dkati commented 7 years ago

:)

mrrhye commented 7 years ago

Hi, im using jdct optimized cm13 stable 4

On 21 October 2016 4:13:05 PM AWST, B--B notifications@github.com wrote:

What rom and variant is affected by this issue?

You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/JDCTeam/issue_tracking_cm/issues/105#issuecomment-255321284

mrrhye commented 7 years ago

Sorry for lack of info, i am using jdct optimized cm13 stable-4,

On 21 October 2016 4:21:45 PM AWST, Dimitris Katikaridis notifications@github.com wrote:

I made some changes to Optcm 13 about ledify. But it was a bit strange at cm14 too. I work on both roms together so yes I would check it. Since the bug is reported on cm issue tracking I guess it's one of those 2

You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/JDCTeam/issue_tracking_cm/issues/105#issuecomment-255322873