search

JDCalvert / FVTT-PF2e-Ranged-Combat

A module for the Foundry VTT Pathfinder 2e system that provides helper effects and macros for ranged combat.
5 stars 16 forks source link

Ammunition rule elements still ignored in 6.2.1 #184

Closed johncarney closed 4 months ago

johncarney commented 4 months ago

Issue #183 was reported as fixed in version 6.2.1 of PD2e Ranged Combat, but ammunition rule elements are still ignored. The problem is illustrated in the video below.

https://github.com/JDCalvert/FVTT-PF2e-Ranged-Combat/assets/322950/a8b68ac9-9d04-44eb-961e-e6e99e12b1ae

TheGnome1 commented 4 months ago

just tested ... if you actually Fire the arrow and roll damage from attack card it works... just trying to roll damage from the sheet will not work however.

johncarney commented 4 months ago

just tested ... if you actually Fire the arrow and roll damage from attack card it works... just trying to roll damage from the sheet will not work however.

Aha. Thanks. So it's a workable fix, though it would be nice if rolling damage from the actions tab would work as well.

JDCalvert commented 4 months ago

My apologies, I should have explained that in the previous issue!

In the module's implementation of ammunition effects, the effect is applied when you fire and is then removed when you roll damage (or fire again). This is changed from the system's implementation to fix #175.

I think the best way around this is likely an option to revert to the system's implementation (so you can change ammunition type between firing and damaging) and a warning if rolling damage with ammunition selected that doesn't match the effect currently applied.

johncarney commented 4 months ago

Thanks for the explanation. Given that rolling damage without a preceding strike, or changing ammo after a strike are rare use-cases, I'm happy with things as they stand.

If it's possible, a simple warning that things may not work the way the user expects would be great. An option to work around would be the cherry on top.

In any case, thanks for your prompt responses to all of this. PF2e Ranged Combat is a must-have module for me both as a player and a GM and going in to a campaign where I wanted to use cold iron or silver ammunition, having to choose between that and the module was a terrible dilemma 🙃

Thanks for your excellent work.

johncarney commented 4 months ago

PS. I'm working on a basic compendium module with a variety of precious material ammunition. If you're interested in using it for testing purposes, I'll let you know when it's ready.

JDCalvert commented 4 months ago

I've added warnings and an option to disable the ammunition effects system and revert to the system's implementation.

@johncarney that compendium sounds great, I'd love to see it when it's done!

johncarney commented 4 months ago

Awesome. Works a treat. Thanks :)

johncarney commented 4 months ago

I have a few things on my plate right now, but I should have the compendium up in a week or so.

johncarney commented 4 months ago

@johncarney that compendium sounds great, I'd love to see it when it's done!

Prisha's Precious Projectiles is now up on Github. I consider this a private beta, so please do not share.

There are installation instructions and caveats on the Github page.