JDCalvert / FVTT-PF2e-Ranged-Combat

A module for the Foundry VTT Pathfinder 2e system that provides helper effects and macros for ranged combat.
5 stars 16 forks source link

Bug: Ranged combat is not respecting strikes rolled with `consumeAmmo: false` #193

Closed esheyw closed 3 months ago

esheyw commented 3 months ago

I'm writing a macro + effects solution for Fake Out ( my solution ), and as per the PFS note it does not consume ammo. The system has something for this:

//roll the first held weapon at map 0 without consuming ammo
actor.system.actions[0].variants[0].roll({consumeAmmo: false})

This works fine without Ranged Combat, but with it it complains about loading and still consumes the ammo after the strike, disregarding the passed option.

edit: I see that there's supposed to be some Fake Out automation in the module already, but I can't find it (I was writing this as a #macro-polo request, I don't gunslinger myself). Regardless this is still a bug, I think.

JDCalvert commented 3 months ago

I managed to figure out a way round this in 6.3.5. It looks like it works fine in both v11 and v12, so let me know if you have problems!