search

JDHankle / riviera

Remote Debugging in EMACS
GNU Lesser General Public License v2.1
6 stars 1 forks source link

Issue with EMACS packages in EMACS24 #1

Open JDHankle opened 11 years ago

JDHankle commented 11 years ago

What steps will reproduce the problem?

  1. (require 'geben)
  2. M-x erc
  3. Supply values to logon to IRC

What is the expected output? What do you see instead? The expected output should be a successful logon to IRC. Instead the message below is shown:

Connecting to irc.freenode.net:6667... open-network-stream: Wrong type argument: bufferp, nil

What version of the product are you using? On what operating system? 0.24 on Mac OS 10.6.8

Please provide any additional information below.

Here is a backtrace: Debugger entered--Lisp error: (wrong-type-argument bufferp nil) buffer-local-value(dbgp-buffer-process nil) open-network-stream("erc-irc.freenode.net-6667" nil "irc.freenode.net" 6667) erc-server-connect("irc.freenode.net" 6667 #) erc-open("irc.freenode.net" 6667 "carbon99" "unknown" t nil) erc(:server "irc.freenode.net" :port 6667 :nick "carbon99" :password nil) call-interactively(erc t nil) execute-extended-command(nil) call-interactively(execute-extended-command nil nil)

JDHankle commented 11 years ago

Issue caused by rewrite of open-network-stream to pass spawned DBGp client to comint.

(defadvice open-network-stream (around debugclient-pass-process-to-comint) "[comint hack] Pass the spawned DBGp client process to comint." (let* ((buffer (ad-get-arg 1)) (proc (buffer-local-value 'dbgp-buffer-process buffer))) (set-process-buffer proc buffer) (setq ad-return-value proc)))

This causes the error on any ELISP that calls this function.

danlamanna commented 11 years ago

This seems resolved in 24.3, @JDHankle care to test that out?