search

JDKDigital / productive-bees

Useful bees
https://www.curseforge.com/minecraft/mc-mods/productivebees
Other
64 stars 42 forks source link

[QoL] Consider clearing NBT of empty Advanced Hives #378

Open vadcx opened 1 year ago

vadcx commented 1 year ago

These two advanced hives seem to be exactly the same? Only the one has no NBT at all and the other one an "empty" NBT that has no meaning? If so, please consider dismissing these empty NBT tags when the block is mined.

  1. Better UX when similar blocks stack, less confusion (the two blocks are semantically identical to a player)
  2. Less inventory clutter in player inventory
  3. Does not take up different slots in systems like AE2 ME System

productivebees-1.19.2-0.10.5.3.jar

beehive-nbt beehive-no-nbt

JaisDK commented 1 year ago

this is consistent with vanilla hives when silk touched, but I can see why it may be beneficial to remove it when it's technically empty

vadcx commented 1 year ago

I didn't know that, but I still hold onto what I outlined above. Now that Notch is no longer around, who do I get to blame for vanilla code? Jeb_? Dinnerbone? Hm no, apparently Henrik Kniberg (uno, dos)

Funny rambling aside, I guess the tooltip renderer can still display these descriptions even with the NBT tags missing? Sounds like a simple fix (if only I had a working workspace for MC... :smile: )

JaisDK commented 1 year ago

the thing is that these tags are set from the loot table file, it's not code I touch directly

having said that I'm sure there's a way around it