search

JDKMissionControl / jmc

This mirror is deprecated - please start using https://github.com/openjdk/jmc
197 stars 46 forks source link

JMC-6455 - Attach source JARs to the project #3

Closed ferstl closed 5 years ago

ferstl commented 5 years ago

It would be really helpful to have source JARs for your modules. This will provide much better IDE support (code completion, access to documentation, ...) when using the modules as third-party libraries. With the adjustments of this PR Maven will create a source JAR for each module in the core/ directory and install/deploy it to the Maven repository. Furthermore, if you are planning to publish the mission control JARs on Maven Central, you need to provide source (and Javadoc) JARs along with the binaries.

thegreystone commented 5 years ago

Excellent @ferstl! Do you, or the company you work for, have a signed OCA (Oracle Contributor Agreement)?

ferstl commented 5 years ago

I signed and mailed it today but it has not been published on https://www.oracle.com/technetwork/community/oca-486395.html yet.

thegreystone commented 5 years ago

Ok. It will likely take a few days for the OCA to be processed. Please let me know when you've received confirmation!

ferstl commented 5 years ago

Now it's processed and published: https://www.oracle.com/technetwork/community/oca-486395.html#f

thegreystone commented 5 years ago

Thanks for your contribution Stefan!