search

JDKMissionControl / jmc

This mirror is deprecated - please start using https://github.com/openjdk/jmc
197 stars 46 forks source link

JMC-6460 - Provide simple mechanism for building JMC under Docker #4

Closed willthames closed 5 years ago

willthames commented 5 years ago

Use docker-compose to create appropriate containers for following the build instructions, and put the result in the target directory.

Instructions are provided

klaraward commented 5 years ago

This is awesome :)

thegreystone commented 5 years ago

Excellent! Will, do you have a signed OCA (Oracle Contributor Agreement)?

thegreystone commented 5 years ago

@willthames - we can't accept contributions to the JMC project without a signed OCA, just like contributions to Eclipse needs an ECL etc. It's a very simple procedure. Let me know if you need any assistance.

willthames commented 5 years ago

@thegreystone sorry, I missed your earlier comment there. It looks fairly straightforward so I'll try and sort out the paperwork in the next few days

thegreystone commented 5 years ago

@thegreystone sorry, I missed your earlier comment there. It looks fairly straightforward so I'll try and sort out the paperwork in the next few days

Excellent! Thanks a bunch! :)

willthames commented 5 years ago

@thegreystone my OCA came through the other day - I'm on the list now.

thegreystone commented 5 years ago

Excellent! Thanks Will!

thegreystone commented 5 years ago

Was a bit too quick - JMC should be built with JDK 8 for now, and I run into some trouble unless I switch to using JDK 8. @willthames - do you mind if I amend the final check-in into the mercurial repo by instead doing FROM openjdk:8-jdk-stretch?

willthames commented 5 years ago

@thegreystone whatever works for you but this works perfectly for me under JDK 11 - what is the issue that needs this to be built under JDK 8?

thegreystone commented 5 years ago

Hm. Weird, we never got the tooling to work properly under JDK 11, but perhaps the updates to the latest and greatest make it easier. For me it failed. Perhaps we can take a closer look later, but core is intended to be built with JDK 7 (still used by code at Oracle that I think still runs on JDK 7 for certain services), and the app is intended to be runnable in Eclipse running on a JDK 8.

Either way, thank you for the contribution!