search

JDNdeveloper / Off-By-One

CMPS 115 Project: Jayden Navarro, John Gemignani, Alex Gonzalez, Kevin Cheng, Josh Innis
0 stars 0 forks source link

Handle new Notifications correctly with Actions #106

Closed JDNdeveloper closed 9 years ago

JDNdeveloper commented 9 years ago

Currently the notifications are not tied to new actions when they're created which they should be. You need to create a new action whenever you create a new notification and you need to tie the action key to the Notification's action key variable.

JDNdeveloper commented 9 years ago

I did this in MainActivity when new notifications are created. Make sure this happens in ReminderActivity when new notifications are created inside of there.

JoshInnis commented 9 years ago

I haven't done this in notification, did you do it there too?

JDNdeveloper commented 9 years ago

I did it in Main when you add a new one. You'll need to do this in Reminder Activity. On Mar 3, 2015 9:25 PM, "JoetheSoda" notifications@github.com wrote:

I haven't done this in notification, did you do it there too?

— Reply to this email directly or view it on GitHub https://github.com/JDNdeveloper/Off-By-One/issues/106#issuecomment-77099287 .

JoshInnis commented 9 years ago

When I changed how creating a new notification works in main activity this must have gotten lost, because when I tested it, by creating a notification in MainActivity it said the actionKey was "Failed_Action_X" x being a number, I fixed this so now its there, and it doesnt say it has a failed action key anymore.