search

JDNdeveloper / Off-By-One

CMPS 115 Project: Jayden Navarro, John Gemignani, Alex Gonzalez, Kevin Cheng, Josh Innis
0 stars 0 forks source link

Make Scrollviews of events full screen #15

Closed JDNdeveloper closed 9 years ago

JohnGemignani commented 9 years ago

This can be done. However, I don't feel it is necessary to do it right now or make a separate task. We are going to be adjusting a lot on the adapters and UI tweaks will be part of that. Closing for now.

JDNdeveloper commented 9 years ago

I don't think we should close issues just because we don't want to work on them currently. If we close them then we'll forget about them.

JDNdeveloper commented 9 years ago

I will take this on. Don't worry about it.

JDNdeveloper commented 9 years ago

@agonza26 This is something you could do as well.

agonza26 commented 9 years ago

@JDNdeveloper so right now I removed the margins so that it looks as though when you scroll it goes behind the action bar, is that what you want? i'll commit to my branch and show you what it is

JDNdeveloper commented 9 years ago

I don't want it to be behind the action bar. Pretend that the white area beneath the action bar is the entire screen. I just want it to fill that area, not any other area. Currently it doesn't cover that whole space. I want it just to cover that space, not hide behind anything, but completely cover that space.

agonza26 commented 9 years ago

i still dont think i understand what you mean by cover, right now its not behind the action bar, it stops right underneath it. are you saying the action bar should scroll with the page? or do you want the text to reach edge to edge? @JDNdeveloper

JDNdeveloper commented 9 years ago

I think you have it the way I have in mind. I'll confirm later tonight. On Feb 15, 2015 7:42 PM, "agonza26" notifications@github.com wrote:

i still dont think i understand what you mean by cover, right now its not behind the action bar, it stops right underneath it. are you saying the action bar should scroll with the page? or do you want the text to reach edge to edge?

— Reply to this email directly or view it on GitHub https://github.com/JDNdeveloper/Off-By-One/issues/15#issuecomment-74456301 .

JDNdeveloper commented 9 years ago

I think this has been accomplished.