search

JDRF / design-system

JDRF Design System
http://jdrf.github.io/design-system
MIT License
15 stars 20 forks source link

Custom selects' options are white on white on Windows #383

Closed noahcooper closed 7 years ago

noahcooper commented 8 years ago

In /src/scss/_custom-forms.scss, .c-select is set to color: transparent. This results in selects' options appearing to be white on white when opened. The option text is only visible when selected.

It looks like this only happens on Windows -- Mac seems to ignore the transparent color declaration.

briansaycocie commented 7 years ago

Thanks for finding that issue @noahcooper. I can confirm the issue exists in Chrome v54 - Windows 10.

I've just submitted a PR to resolve the issue. It appears the color: transparent and text-shadow: 0 0 0 #000 was added to resolve a specific Firefox issue displaying a focused dotted outline. I've moved those styles into a :-moz-focusring pseudo selector so it's only applied to Firefox.

Closing out.