search

JDRF / design-system

JDRF Design System
http://jdrf.github.io/design-system
MIT License
15 stars 20 forks source link

Bootstrap v4's Labels component no longer exists #385

Closed briansaycocie closed 7 years ago

briansaycocie commented 7 years ago

When the DS Badge's component was built, it was based on Bootstrap v4 Label's component which I come to find out, no longer exists as of v4.0.0-alpha.3 (current implementation is based on v4.0.0-alpha.2). This component has been replaced with the Tag's component according to their migration documentation.

Basically, this means new developers that set up Design Systems locally will have an issue compiling SASS as its importing the Labels SASS partial @import 'scss/labels' from npm (which no longer exists if you do a recent npm install as I come to find out while troubleshooting a separate issue). My workaround for this was to get a copy of another developer's node_modules folder that has worked on this repo previously (got it from Nick) and replaced it with mine, which isn't ideal.

My recommendation: Rework the DS Badge's component to utilize the new Bootstrap v4 Tag's component.

patrickmckowen commented 7 years ago

@briansaycocie thanks for catching this. I've opened a ticket: https://trello.com/c/XRQkyjvn

mrbobbybryant commented 7 years ago

We have decided to lock in the current version of bootstrap so that future changes will not break existing features. Thanks @briansaycocie for pointing out this issue.

This was fixed by the following pull request. https://github.com/JDRF/design-system/pull/390