Open McCallumDillon opened 8 years ago
This is an interesting enhancement, but not something we can do right now.
@RachelRVasquez This is #3 . I'd like to make it similar to the Bootstrap docs site as well with links directly to each HEADER (h1,h2,h3) section element - Screenshot - Link
@fuhton Are we adding a "Contents" area above each component section the way Bootstrap does then? And then making every H3 within each component a jump link?
This might be overkill depending on the headings within each component. I'd imagine for jump links to be efficient the way Bootstrap has it, we'd need to re-structure and that doesn't sound like it'd be viable option at this point in the Design System.
If this issue is mainly mobile, I'd agree with Dillon on trying a back to top button? Or perhaps collapsing those H3 sections on mobile for easier scrolling? Thoughts?
Let's just do the original suggestion.
On Wednesday, September 21, 2016, RachieVee notifications@github.com wrote:
@fuhton https://github.com/fuhton Are we adding a "Contents" area above each component section the way Bootstrap does then? And then making every H3 within each component a jump link?
- Buttons - Component Level -- Primary -- Outline -- Flat etc.
This might be overkill depending on the headings within each component. I'd imagine for jump links to be efficient the way Bootstrap has it, we'd need to re-structure and that doesn't sound like it'd be viable option at this point in the Design System.
If this issue is mainly mobile, I'd agree with Dillon on trying a back to top button? Or perhaps collapsing those H3 sections on mobile for easier scrolling? Thoughts?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/JDRF/design-system/issues/45#issuecomment-248645618, or mute the thread https://github.com/notifications/unsubscribe-auth/ABxZDqWwvu9L3IsZ1VIrM74TF5kRl8tlks5qsUtcgaJpZM4Is5sz .
@fuhton PR submitted: https://github.com/JDRF/design-system/pull/376
Merged and pushed.
@fuhton Are we putting this through any visual QA or can we just close out now that we've merged/pushed?
@RachelRVasquez I checked it locally. I'll assign to Patrick to get his confirmation.
This may be overkill, but one thing I noticed on mobile was “a lot of scrolling” for certain sections. If you go to "http://jdrf.github.io/design-system/dist/content.html#typography” on mobile it is a lot of effort to reach back to the top of the page to access the menu. How do you feel about something like “headroom.js” or a ‘scroll to top’ button?