search

JDShu / SCOPE

Other
0 stars 2 forks source link

Test FOLLOWED link from user profile #133

Closed maxwward closed 11 years ago

maxwward commented 11 years ago

I've tested this as a user with followed exercises and without and the result is the same.

Not sure what the search action is trying to do...

I think the behavior should be simplified to take you to all followed exercises just as clicking FOLLOWED from the ALL page does.

What do you think?

tyrrminal commented 11 years ago

I can't reproduce this. Screenshots of my local install, and the heroku install:

Screen Shot 2013-03-11 at 12 20 39 AM Screen Shot 2013-03-11 at 12 22 11 AM

maxwward commented 11 years ago

I can't seem to reproduce it this morning either. Let me test again and see what I come up with.

maxwward commented 11 years ago

This is still a problem. Test the "followed" link from commonsense profile (id commonsense, pw commonsense) and you get the message below. I don't understand/intuit what the result should be, but the message from the application is to follow users or exercises in order to see something. Problem is that commonsense is following both users and exercises. This feature does seem to work somehow for other user profiles, so I think the real issue is that I don't understand what should be showing.

Screen Shot 2013-03-30 at 12 45 53 PM Screen Shot 2013-03-30 at 12 46 16 PM

tyrrminal commented 11 years ago

Ok, I see what's going on here. The FOLLOWED filter, from the user page, is applying an additional filter to the view - I believe that it's only showing exercises that were created and followed by the user. This behavior is reproducible on other users. It shouldn't be difficult to eliminate this behavior.

maxwward commented 11 years ago

Ok, I get it. If you follow your own exercise, then from the user profile click on followed, it shows you the exercises of your own that are followed. Fine.

Let's leave this alone and spend our time working on other things.

Unless you think we should fix it now.... I shouldn't say fix it...it isn't really broken, but maybe it is a little unintuitive.

On Sat, Mar 30, 2013 at 1:02 PM, objcow notifications@github.com wrote:

Ok, I see what's going on here. The FOLLOWED filter, from the user page, is applying an additional filter to the view - I believe that it's only showing exercises that were created and followed by the user. This behavior is reproducible on other users. It shouldn't be difficult to eliminate this behavior.

— Reply to this email directly or view it on GitHubhttps://github.com/JDShu/SCOPE/issues/133#issuecomment-15677847 .