search

JDetmar / NLog.Extensions.AzureStorage

NLog Target for Azure Storage. Uses NLog batch write to optimize writes to Storage.
MIT License
31 stars 19 forks source link

Sign released assemblies #122

Closed Oxfald closed 2 years ago

Oxfald commented 2 years ago

Hello, is it possible/planned to sign released assemblies?

snakefoot commented 2 years ago

Thought it only made sense to sign assemblies when using classic .NET Framework platform.

See also: https://github.com/dotnet/runtime/blob/main/docs/project/strong-name-signing.md#1-microsoft-strong-names-their-assemblies-should-i

For .NET Core and .NET 5+, strong-named assemblies do not provide material benefits. The runtime never validates the strong-name signature, nor does it use the strong-name for assembly binding.

All the nuget-packages targets .NET Standard 2.0, and not .NET Framework.

Oxfald commented 2 years ago

Thank you for the link, I was not aware about it. Still I am stuck with a specific issue when we need to use [InternalsVisibleTo] attribute which requires strongly-names assemblies (typical use case for exposing internals to UnitTests project) I was not able to fine any alternative to this attribute, so it might be helpful to have assemblies signed even if it is no longer useful on production environment.

snakefoot commented 2 years ago

InternalsVisibleTo also works just with assembly-name without the strong-name Guid.

Oxfald commented 2 years ago

Oh yes, I though that I tested it properly, I mixed some changes in my project. Sorry for the unnecessary issue creation. Thank you =)