Model supports flexible additional attributes

JDutil / contact_us

Gem providing simple Contact Form functionality with a Rails 3+ Engine.

http://contact-us-demo.herokuapp.com

MIT License

135 stars 57 forks source link

Model supports flexible additional attributes #20

Closed betesh closed 11 years ago

betesh commented 11 years ago

The main change in here is that you can add attributes to the model. Corresponding additions in views are best handled on an application-by-application basis. None of this is tested--I couldn't get rspec or rake to run tests so please guide me in the right direction.

JDutil commented 11 years ago

I'm not in favor of the changes to the validations and views, and this entirely breaks the tests. I'm closing this out.

I'm a bit interested in the method for adding attributes, and would be open to considering the change if you could resubmit with only that change and passing tests. I think that may be a nicer way to give people the flexibility setting which attributes they would like to collect than the current configuration.