search

JECSand / yahoofinancials

A powerful financial data module used for pulling data from Yahoo Finance. This module can pull fundamental and technical data for stocks, indexes, currencies, cryptos, ETFs, Mutual Funds, U.S. Treasuries, and commodity futures.
https://pypi.python.org/pypi/yahoofinancials
MIT License
911 stars 215 forks source link

yahoo issue was the client version #61

Closed sylvandb closed 3 years ago

sylvandb commented 4 years ago

A few days ago I had problems with yahoofinancials, and tracked it down to getting different results from yahoo than the module expected, because Yahoo was trying to be smart in responding to the client version string.

This commit changes the client version string.

I expect (and for me it does): Fixes #57 Fixes #58 Fixes #59

thaschbe commented 4 years ago

fix is working Thank you very much! I was debugging for some hours this morning - without success. This does it! Great work!

RomSe79 commented 4 years ago

fix works well, thanks a lot!

beckshaur23 commented 4 years ago

Hi Sylandb, how did you figure out the root cause of this issue? Thanks for the work around, this is indeed useful to fix all the other issues. Hopefully the PR can be approved soon 👍

shaunpatterson commented 4 years ago

Can we get this merged?

jabarny commented 4 years ago

is this package now deprecated?