search

JECSand / yahoofinancials

A powerful financial data module used for pulling data from Yahoo Finance. This module can pull fundamental and technical data for stocks, indexes, currencies, cryptos, ETFs, Mutual Funds, U.S. Treasuries, and commodity futures.
https://pypi.python.org/pypi/yahoofinancials
MIT License
911 stars 215 forks source link

Fix upstream #72

Closed sylvandb closed 3 years ago

sylvandb commented 4 years ago

accumulated fixes, see commit comments

includes pr #61 which: Fixes #57 Maybe Fixes? #58 Maybe Fixes? #59

Adds: Fixes 'adjusted-close' aspect of #64 Fixes #71

HyperionSounds commented 4 years ago

how can we merge this with the master so it will pip install? I am running my platform across multiple environments

cliffchew84 commented 4 years ago

Thanks. This helped me fixed my issue. I wasn't able to figure out how to merge this with my pip install, and I just modified the code based on the code changes made here.

juanmf commented 4 years ago

Thanks. This helped me fixed my issue. I wasn't able to figure out how to merge this with my pip install, and I just modified the code based on the code changes made here.

it'd be cool to have pip installing this, or at least having this branch installed without manually modifying the code. any link on how to do it?

tried this with no luck:

pip install git+https://github.com/sylvandb/yahoofinancials@fix-upstream

so just edited files and worked, thanks!

krema commented 4 years ago

@sylvandb Can you please make a separate pull request for the bs4 change? There are so many "maybe" fixes in this pull request that it will probably never be merged. I am happy to help if you want me to do it.

@ThomasGsp Or can we merge it already?

@juanmf pip install -e git+https://github.com/sylvandb/yahoofinancials.git#egg=yahoofinancials

sylvandb commented 4 years ago

@krema @juanmf I'm not sure that pip command line will do what you desire. I do not use pip like that, but that command appears like it will take my master branch which has diverged in several ways from the upstream version in this repo. I have tried for only improvements, but it may not work outside of my specific use case. I use only a small portion of the functionality...

The previous PR should be merged first or @JECSand could cherry-pick individual commits as desired.

Of course please feel free to take individual commits or even create new commits from my work.

krema commented 4 years ago

@sylvandb Thank you for your efforts but this project appears to be dead. I don't want to spend any more time fixing problems in this project. There are too many unresolved issues. The last release was 17 month ago. I switched to another project (yahooquery) that is active and even has yahoo premium support.

JECSand commented 3 years ago

Hey all,

I’ve been in the process of starting my own business. I had no idea this would become so popular. Haven’t checked on this in awhile. I made the merges into the base branch just now. I’ll be on here paying more attention.

Really apologize for any inconveniences.