JEFworks / MUDAN

Multi-sample Unified Discriminant ANalysis
http://jef.works/MUDAN/
GNU General Public License v3.0
72 stars 12 forks source link

use Remotes: to install sva from bioconductor #4

Closed slowkow closed 4 years ago

slowkow commented 5 years ago

I tried to install MUDAN and got:

$ R CMD INSTALL .
* installing to library ‘/Library/Frameworks/R.framework/Versions/3.6/Resources/library’
ERROR: dependency ‘sva’ is not available for package ‘MUDAN’
* removing ‘/Library/Frameworks/R.framework/Versions/3.6/Resources/library/MUDAN’

This pull request eliminates the installation error that I ran into.

diff --git a/DESCRIPTION b/DESCRIPTION
index acc33fe..512801b 100644
--- a/DESCRIPTION
+++ b/DESCRIPTION
@@ -12,8 +12,9 @@ RoxygenNote: 6.0.1
 Depends:
     R (>= 2.10),
     Matrix
+Remotes:
+    bioc::release/sva
 Imports:
-    sva,
     mgcv,
     irlba,
     RANN,

This page shows how we can use Remotes: to install from Bioconductor, GitHub, GitLab, or other sources:

https://cran.r-project.org/web/packages/devtools/vignettes/dependencies.html

slowkow commented 5 years ago

Sorry, I think I made a mistake. I just tried it again after removing sva and MUDAN, and I get a new error after my pull request:

Error in loadNamespace(j <- i[[1L]], c(lib.loc, .libPaths()), versionCheck = vI[[j]]) :
  there is no package called ‘sva’
Calls: <Anonymous> ... loadNamespace -> withRestarts -> withOneRestart -> doWithOneRestart
Execution halted

I can work around this by installing sva manually with:

BiocManager::install("sva")

After searching around, I re-discovered this gem:

https://github.com/r-lib/devtools/issues/700#issuecomment-235127291

image

Unfortunately, even after I added biocViews: to the DESCRIPTION file and I still get an error:

ERROR: dependency ‘sva’ is not available for package ‘MUDAN’
JEFworks commented 4 years ago

Addressed via pull #9