search

JEG2 / highline

A higher level command-line oriented interface.
Other
1.29k stars 137 forks source link

Some fixes for Rubinius and dropping of 1.8 support #134

Closed abinoam closed 9 years ago

abinoam commented 9 years ago

I've made some effort to make the travis green for Rubinius. @bjfish may be interested as he made the PR #132 .

I have applied @elyscape suggestion on this commit (0dfa369c3d1).

But, sadly it would be a huge effort to "recover" 1.8 compatibility as we have recently introduced some improvements on multi-byte character handling that relies heavily on Encoding (lacking in 1.8). So I decided to drop 1.8 support entirely from the code and from travis build matrix.

Do you agree @JEG2 ?

The tests are passing fine in my local machine and on travis.

But... @elyscape, @markwetter and @viyh could please test the current code on your enviroments?

JEG2 commented 9 years ago

I do agree that it's fine to drop 1.8 support. 1.9.3 is no longer maintained and we'll still support it. We're meeting our due diligence, in my opinion.

abinoam commented 9 years ago

Hold on the merge. I'll try to arrange for a release altogether.

bjfish commented 9 years ago

:+1:

elyscape commented 9 years ago

So long as 1.7.0 is yanked, 1.8 environments should be fine.

abinoam commented 9 years ago

Travis all green! I think we're ready for release @JEG2

markwetter commented 9 years ago

@abinoam I just tested your fork, and itappears to be working correctly.

Thanks!

JEG2 commented 9 years ago

1.7.0 yanked. 1.7.1 pushed.

abinoam commented 9 years ago

:+1: @JEG2 And thanks for testing @markwetter