JEG2 / highline

A higher level command-line oriented interface.
Other
1.29k stars 137 forks source link

Issue #138 #139

Closed abinoam closed 9 years ago

abinoam commented 9 years ago

Related to #138

As a fast fix I just reapplied the commit and bumped up the version.

@KrauseFx, could you check if this fix for you before @JEG2 makes a new release? (I'm not able to reproduce neither the fail nor the fix by now).

KrauseFx commented 9 years ago

Thanks for the quick fix!

Sorry, I somehow can't install the version from the issue_138 branch, I cloned and ran bundle install && sudo rake install. Installation works fine, but as soon as a import commander the following is shown:

/Users/felixkrause/.rvm/rubies/ruby-2.0.0-p481/lib/ruby/site_ruby/2.0.0/rubygems/core_ext/kernel_require.rb:135:in `require': cannot load such file -- highline/import (LoadError)

The same in irb:

$ irb
> require 'highline'
LoadError: cannot load such file -- highline
    from /Users/felixkrause/.rvm/rubies/ruby-2.0.0-p481/lib/ruby/site_ruby/2.0.0/rubygems/core_ext/kernel_require.rb:55:in `require'

If I do a gem install highline to install the last official release the require is working fine.

abinoam commented 9 years ago

Hi @KrauseFx ,

Try rake install without sudo.

Perhaps the use of sudo here could try to install the gem into a multi user rvm install (at /usr/local/rvm, not at ~/.rvm). Not sure. (https://rvm.io/rvm/install)

Any way, I have managed to test it over here with...

ruby -e "require 'commander'; ask('hi therehi therehi therehi therehi therehi therehi therehi therehi therehi therehi therehi therehi therehi therehi there')"

... against the 2 versions.

I think is safe for @JEG2 to merge now.

And thanks for reporting the issue.

JEG2 commented 9 years ago

I'll make a release if @KrauseFx reports this is working…

KrauseFx commented 9 years ago

@abinoam Thanks for the quick fix @JEG2 Sorry it took so long, but I finally got the gem working. It's working fine and solves the problem :+1:

Thank you for you help!

JEG2 commented 9 years ago

I just released the fix.

KrauseFx commented 9 years ago

Thank you @JEG2, really appreciated :+1: